Skip to content

Commit

Permalink
Remove Snapshot INIT Step (elastic#55918)
Browse files Browse the repository at this point in the history
With elastic#55773 the snapshot INIT state step has become obsolete. We can set up the snapshot directly in one single step to simplify the state machine.

This is a big help for building concurrent snapshots because it allows us to establish a deterministic order of operations between snapshot create and delete operations since all of their entries now contain a repository generation. With this change simple queuing up of snapshot operations can and will be added in a follow-up.
  • Loading branch information
original-brownbear committed May 5, 2020
1 parent 7156f40 commit f4022c0
Show file tree
Hide file tree
Showing 6 changed files with 106 additions and 374 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ public void clusterStateProcessed(String source, ClusterState oldState, ClusterS
l -> blobStoreRepository.cleanup(
repositoryStateId,
snapshotsService.minCompatibleVersion(
newState.nodes().getMinNodeVersion(), repositoryName, repositoryData, null),
newState.nodes().getMinNodeVersion(), repositoryData, null),
ActionListener.wrap(result -> after(null, result), e -> after(e, null)))
));
}
Expand Down
Loading

0 comments on commit f4022c0

Please sign in to comment.