Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding quagga_interface type and provider #8

Merged
merged 1 commit into from
Jun 11, 2017

Conversation

m4ce
Copy link
Contributor

@m4ce m4ce commented Jun 9, 2017

Dmitriy, have a look at this.

I've also added support for the ipaddress parameter. I still need to add the logic around the ensure => shutdown. However, it handles the ensure => absent correctly now.

@m4ce
Copy link
Contributor Author

m4ce commented Jun 9, 2017

I've actually added the enable option (true or false) to decide whether an interface should be enabled or shutdown. It seems to be cleanest really.

end
end

ensurable do
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I remove the system interface?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bibigon812 - hm, I guess it will not actually remove the virtual device associated to the physical nic itself but it will effectively shut it down. However, let's say you define a new logical interface, e.g. tun0, and you want to remove it after, you still need a way of doing that, that is where ensure => absent comes in.

I guess 'ensure => absent' should be used with care. If one wants to enable or disable (shutdown) the interface, enable => true/false would do the trick.

@bibigon812 bibigon812 merged commit 0c1b0dc into bibigon812:master Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants