Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ethereum transfer fee #1328

Merged
merged 1 commit into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pallets/flexible-fee/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,8 @@ impl<T: Config> Pallet<T> {
ExtraFeeName::SalpContribute |
ExtraFeeName::VoteVtoken |
ExtraFeeName::VoteRemoveDelegatorVote => T::PalletId::get().into_sub_account_truncating(0u64),
ExtraFeeName::StatemineTransfer => T::PalletId::get().into_sub_account_truncating(1u64),
ExtraFeeName::StatemineTransfer | ExtraFeeName::EthereumTransfer =>
T::PalletId::get().into_sub_account_truncating(1u64),
ExtraFeeName::NoExtraFee => T::TreasuryAccount::get(),
}
}
Expand Down Expand Up @@ -493,6 +494,7 @@ impl<T: Config> Pallet<T> {
let operation = match fee_info.extra_fee_name {
ExtraFeeName::SalpContribute => XcmOperationType::UmpContributeTransact,
ExtraFeeName::StatemineTransfer => XcmOperationType::StatemineTransfer,
ExtraFeeName::EthereumTransfer => XcmOperationType::EthereumTransfer,
ExtraFeeName::VoteVtoken => XcmOperationType::Vote,
ExtraFeeName::VoteRemoveDelegatorVote => XcmOperationType::RemoveVote,
ExtraFeeName::NoExtraFee => XcmOperationType::Any,
Expand Down
1 change: 1 addition & 0 deletions primitives/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ pub enum ExtraFeeName {
VoteVtoken,
VoteRemoveDelegatorVote,
NoExtraFee,
EthereumTransfer,
}

// For vtoken-minting and slp modules
Expand Down
6 changes: 6 additions & 0 deletions runtime/bifrost-polkadot/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -923,6 +923,12 @@ impl FeeGetter<RuntimeCall> for ExtraFeeMatcher {
extra_fee_name: ExtraFeeName::StatemineTransfer,
extra_fee_currency: RelayCurrencyId::get(),
},
RuntimeCall::XcmInterface(bifrost_xcm_interface::Call::transfer_ethereum_assets {
..
}) => ExtraFeeInfo {
extra_fee_name: ExtraFeeName::EthereumTransfer,
extra_fee_currency: RelayCurrencyId::get(),
},
RuntimeCall::VtokenVoting(bifrost_vtoken_voting::Call::vote { vtoken, .. }) =>
ExtraFeeInfo {
extra_fee_name: ExtraFeeName::VoteVtoken,
Expand Down