Rebalance swarm when necessary #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesbelkada
force-pushed
the
extract-module-container
branch
from
c349b5b
to
74c1b11
Compare
younesbelkada
force-pushed
the
extract-module-container
branch
from
eccb4ad
to
fdb0f73
Compare
borzunov
force-pushed
the
extract-module-container
branch
from
33f3291
to
b5d54f4
Compare
borzunov
changed the title
borzunov
force-pushed
the
extract-module-container
branch
from
9191963
to
f3ea120
Compare
borzunov
force-pushed
the
extract-module-container
branch
3 times, most recently
from
5b2406d
to
2308245
Compare
borzunov
changed the title
borzunov
force-pushed
the
extract-module-container
branch
from
2308245
to
3c292fc
Compare
borzunov
force-pushed
the
extract-module-container
branch
from
3c292fc
to
4a05f40
Compare
| @@ -29,76 +30,13 @@ | |||
|
|
|||
|
|
|||
| class Server(threading.Thread): | |||
| """Serves one or more bloom layers for inference, forward and backward; announces oneself to the DHT""" | |||
| """ | |||
| Runs ModuleContainer, periodically checks that the network is balanced, | |||
There was a problem hiding this comment.
[nit] ModuleContainer sounds somewhat too generic for a class that announces modules to DHT, accepts requests from p2pd, etc
Maybe
- Server -> LoadBalancedServer
- ModuleContainer -> Server
?
There was a problem hiding this comment.
I agree that ModuleContainer is not a perfect name but I didn't come up with better options. If we find one, we can rename this class later.
|
|
||
|
|
||
| class ModuleContainer(threading.Thread): | ||
| """Serves a set of specific Bloom layers for inference, forward, and backward. Announces itself over the DHT.""" |
justheuristic
approved these changes
Oct 11, 2022
borzunov
commented
Oct 11, 2022
src/server/server.py
Outdated
| max_block_selection_delay: float = 1, | ||
| mean_block_selection_delay: float = 0.5, | ||
| mean_balance_check_period: float = 150, | ||
| min_balance_quality: float = 0.8, |
There was a problem hiding this comment.
Suggested change
| min_balance_quality: float = 0.8, | |
| min_balance_quality: float = 0.0, |
TODO: Disable rebalancing by default, unless we solve issues with shmem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: I've tested it on simple cases, it works.
Future work:
Servershould followModuleContainerstatus and restart it if it crashes.block_selection.py.block_selection.py.