Fix bugs in _choose_num_blocks() added in #346 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
commented
Jul 14, 2023
| @@ -249,12 +250,17 @@ def _choose_num_blocks(self) -> int: | |||
| # Estimate of GPU memory used in rpc_backward (2 GiB for BLOOM, proportional for other models) | |||
| autograd_memory = 2 * gib * num_devices / 14336 * self.block_config.hidden_size | |||
|
|
|||
| if adapters: | |||
There was a problem hiding this comment.
adapters is not defined
borzunov
commented
Jul 14, 2023
| # Delay import of petals.utils.peft to avoid unnecessary import of bitsandbytes | ||
| from petals.utils.peft import estimate_adapter_memory_per_block | ||
|
|
||
| adapter_memory_per_block = estimate_adapter_memory_per_block( | ||
| self.block_config, self.torch_dtype, self.adapters, self.cache_dir |
There was a problem hiding this comment.
cache_dir is a kwarg-only. Also, we need all the rest of disk cache args
borzunov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs from #346.