Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and make blocks message more informative #437

Merged
merged 2 commits into from
Aug 6, 2023

Conversation

vadi2
Copy link
Contributor

@vadi2 vadi2 commented Aug 6, 2023

The message really doesn't tell me much as a user, since I never touched update_period to begin with:

Aug 06 09:43:07.287 [WARN] [petals.server.server.run:701] Declaring blocs to DHT takes more than --update_period, consider increasing it

Made it better and more informative.

@borzunov
Copy link
Collaborator

borzunov commented Aug 6, 2023

Hi @vadi2,

Thanks for the PR! I'm fixing the style checker and merging it.

@borzunov borzunov merged commit d0b5af3 into bigscience-workshop:main Aug 6, 2023
7 checks passed
@vadi2 vadi2 deleted the patch-1 branch August 6, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants