Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump transformers and accelerate versions #554

Merged
merged 19 commits into from
Feb 15, 2024

Conversation

dvmazur
Copy link
Collaborator

@dvmazur dvmazur commented Feb 2, 2024

This PR bumps versions for the following dependecies:

  • transformers
  • accelerate

and removes falcon-rw-1b CI tests

@dvmazur dvmazur marked this pull request as draft February 2, 2024 18:52
@mryab mryab marked this pull request as ready for review February 2, 2024 19:04
@mryab mryab changed the title Bump transformers, pert and accelerate versions Bump transformers, peft and accelerate versions Feb 2, 2024
Copy link
Collaborator

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, LGTM!

assert (
version.parse("4.32.0") <= version.parse(transformers.__version__) < version.parse("4.35.0")
), "Please install a proper transformers version: pip install transformers>=4.32.0,<4.35.0"
# assert (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix this?

@dvmazur
Copy link
Collaborator Author

dvmazur commented Feb 13, 2024

todo:

  • version check in falcon
  • fix transformers check in __init__.py
  • try bumping accelerate

@dvmazur dvmazur changed the title Bump transformers, peft and accelerate versions Bump transformers and accelerate versions Feb 14, 2024
assert (
version.parse("4.32.0") <= version.parse(transformers.__version__) < version.parse("4.35.0")
), "Please install a proper transformers version: pip install transformers>=4.32.0,<4.35.0"
version.parse(transformers.__version__) == version.parse("4.37.1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we can safely support up to 4.38.0 (not including that). Can we make it

4.37.1 <= version < 4.38.0 ?

Copy link
Collaborator

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM! Please reflect "removed falcon-rw-1b CI tests" in the squashed commit description.

@dvmazur dvmazur merged commit 0d91bbd into bigscience-workshop:main Feb 15, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants