Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

Fix find docs example #25

Closed
wwilsman opened this issue May 18, 2018 · 0 comments · Fixed by #52
Closed

Fix find docs example #25

wwilsman opened this issue May 18, 2018 · 0 comments · Fixed by #52
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@wwilsman
Copy link
Contributor

Looking over a recent fix for these docs, I realized that the example is actually incorrect. The find property creator returns a getter, so the example should not be .getHeader(), but .header instead.
@Robdel12 Robdel12 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels May 19, 2018
Robdel12 added a commit that referenced this issue Oct 10, 2018
@Robdel12
Pass through all docs and make consistant (and correct minor issues)
ffea946 
This will close #25
Robdel12 added a commit that referenced this issue Oct 10, 2018
@Robdel12
Pass through all docs and make consistant (and correct minor issues)
374d68f 
This will close #25
@Robdel12 Robdel12 mentioned this issue Oct 10, 2018
Merged
Robdel12 added a commit that referenced this issue Oct 10, 2018
@Robdel12
Pass through all docs and make consistant (and correct minor issues) (#…
504288d 
…52)

* Pass through all docs and make consistant (and correct minor issues)

This will close #25

* Update CHANGELOG

* Remove `await` from `find` & `find-all` examples
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass through all docs and make consistant (and correct minor issues) bigtestjs/interactor
2 participants
@Robdel12 @wwilsman