Merge pull request #929 from biigle/patch-1

Fix controller to update volume metadata
biigle · Sep 24, 2024 · db17160 · db17160
2 parents 9449164 + 54918b5
commit db17160
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/Http/Controllers/Api/Volumes/MetadataController.php b/app/Http/Controllers/Api/Volumes/MetadataController.php
@@ -81,7 +81,7 @@ public function store(StoreVolumeMetadata $request)
         // is not guaranteed that the file is overwritten.
         $request->volume->deleteMetadata();
         $request->volume->saveMetadata($request->file('file'));
-        $request->volume->update(['metadata_parser' => $request->input('metadata_parser')]);
+        $request->volume->update(['metadata_parser' => $request->input('parser')]);
         Queue::push(new UpdateVolumeMetadata($request->volume));
     }
 

diff --git a/tests/php/Http/Controllers/Api/Volumes/MetadataControllerTest.php b/tests/php/Http/Controllers/Api/Volumes/MetadataControllerTest.php
@@ -83,6 +83,8 @@ public function testStoreImageMetadata()
         ])
             ->assertStatus(200);
 
+        $this->assertSame(ImageCsvParser::class, $this->volume()->fresh()->metadata_parser);
+
         Queue::assertPushed(UpdateVolumeMetadata::class, function ($job) {
             $this->assertEquals($this->volume()->id, $job->volume->id);
 
@@ -130,6 +132,8 @@ public function testStoreVideoMetadataCsv()
         ])
             ->assertSuccessful();
 
+        $this->assertSame(VideoCsvParser::class, $this->volume()->fresh()->metadata_parser);
+
         Queue::assertPushed(UpdateVolumeMetadata::class, function ($job) {
             $this->assertEquals($this->volume()->id, $job->volume->id);