Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with unchanged label color after swap #625

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Fix bug with unchanged label color after swap #625

merged 6 commits into from
Aug 7, 2023

Commits on Jul 13, 2023

  1. Resolve #493 by adding a refreshAnnotation method 

    Annotations were not updated because the annotation watcher
was not triggered by the color change. Add a refreshAnnotation method
which replaces the old annotation by the new one in the annotationSource.
    @lehecht
    lehecht committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    42763b9 View commit details
    Browse the repository at this point in the history

  2. Update label color for video annotations 

    Label color wasn't updated because 'refresh' event wasn't triggered.
Add refreshAnnotation method and emit event to call it after successfully
detaching annotation.
    @lehecht
    lehecht committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    593aec3 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Remove newlines

    @lehecht
    lehecht committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    285ea32 View commit details
    Browse the repository at this point in the history

  2. Move refresh call to detachAnnotationLabel method 

    Annotation should be updated after swap or label deletion.
    @lehecht
    lehecht committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    e907066 View commit details
    Browse the repository at this point in the history

  3. Rename method for more clarity

    @lehecht
    lehecht committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    2d32a75 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Apply suggestions from code review

    @mzur
    mzur authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    2faa001 View commit details
    Browse the repository at this point in the history