Resolve Utf8 bug #632
Merged
Resolve Utf8 bug #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzur
requested changes
Aug 7, 2023
There was a problem hiding this comment.
Now I understand the problem better. It seems that there was invalid user input (a string instead of a file). So in addition to also accepting a string in the Utf8 rule, we should prepend bail to the validation rules, so they fail already if the value is not a file and skip the remaining rules.
tests/php/Http/Controllers/Api/Volumes/MetadataControllerTest.php
Outdated
Show resolved
Hide resolved
tests/php/Http/Controllers/Api/Volumes/MetadataControllerTest.php
Outdated
Show resolved
Hide resolved
mzur
requested changes
Aug 8, 2023
mzur
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check value type and add test case.