Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks for (non-)simple polygons #634

Merged
merged 40 commits into from
Nov 21, 2023
Merged

Add checks for (non-)simple polygons #634

merged 40 commits into from
Nov 21, 2023

Commits on Aug 3, 2023

  1. Add check for invalid shapes 

    Rectangles, polygons and lineStrings require a minimum number
of non-overlapping vertices now.
    @lehecht
    lehecht committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    0d05256 View commit details
    Browse the repository at this point in the history

  2. Show message for invalid shapes

    @lehecht
    lehecht committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    a821c82 View commit details
    Browse the repository at this point in the history

  3. Rename method for more clarity

    @lehecht
    lehecht committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    92ff004 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Remove case that is not reachable

    @lehecht
    lehecht committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    f65c261 View commit details
    Browse the repository at this point in the history

  2. Add event listener only once

    @lehecht
    lehecht committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b5078d1 View commit details
    Browse the repository at this point in the history

  3. Simplify event listener method

    @lehecht
    lehecht committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    af7dfc3 View commit details
    Browse the repository at this point in the history

  4. Concatenate x,y coordinates before size check

    @lehecht
    lehecht committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2fdf82a View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Remove duplicated coordinates

    @lehecht
    lehecht committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    50c15ae View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Remove superfluous checks for rectangles, ellipses and lines 

    Bug fix #550 already disallows duplicated points for
rectangles and ellipses. Lines could not be drawn as
points by default.
    @lehecht
    lehecht committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e9ac4f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Move magic wand methods to MagicWandInteraction.js

    @lehecht
    lehecht committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    66f4040 View commit details
    Browse the repository at this point in the history

  2. Add jsts library

    @lehecht
    lehecht committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    0940d4c View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Disallow self intersecting polygons 

    Self intersecting polygons are detected and divided
into smaller polygons. Eventually select biggest polygon
by computing its area.
    @lehecht
    lehecht committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b164600 View commit details
    Browse the repository at this point in the history

  2. Remove unused imports

    @lehecht
    lehecht committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0c7a70d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Move polygon validation methods to own class

    @lehecht
    lehecht committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    1c2ba0b View commit details
    Browse the repository at this point in the history

  2. Rename event for more clarity

    @lehecht
    lehecht committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    1894844 View commit details
    Browse the repository at this point in the history

  3. Add polygon validation for video annotations

    @lehecht
    lehecht committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    ca61495 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Fix bug with nested polygon parts 

    Ignore result of symDifference() if next component
is nested in current one. Otherwise overlapping polygon
is returned.
    @lehecht
    lehecht committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1457ae2 View commit details
    Browse the repository at this point in the history

  2. Format code

    @lehecht
    lehecht committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    0316882 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Use value instead of variable

    @lehecht
    lehecht committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    7781541 View commit details
    Browse the repository at this point in the history

  2. Remove superfluous magicwand polygon validation

    @lehecht
    lehecht committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    43f564d View commit details
    Browse the repository at this point in the history

  3. Move polygon validation call to drawInteractions.vue

    @lehecht
    lehecht committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    0c8b012 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Transform self-intersecting polygons to simple ones 

    Separate polygons at cross-points and return
polygon with largest area.
    @lehecht
    lehecht committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    669e94c View commit details
    Browse the repository at this point in the history

  2. Fix missing/unused imports

    @lehecht
    lehecht committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    34f3884 View commit details
    Browse the repository at this point in the history

  3. Remove unused method

    @lehecht
    lehecht committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    a8ddfd1 View commit details
    Browse the repository at this point in the history

  4. Remove unused methods

    @lehecht
    lehecht committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    3f41193 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Make polygonValiator a static class 

    Using class in a object-oriented manner can lead to unexpected behaviour
due to changes on the polygon object, which was the original polygon.
Auxiliary functions aren't exported any more.
    @lehecht
    lehecht committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    66f2fe0 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Remove redundant return statement

    @lehecht
    lehecht committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    398a5ae View commit details
    Browse the repository at this point in the history

  2. Replace class export by methods export

    @lehecht
    lehecht committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    4abce21 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Apply changes from code review

    @mzur
    mzur committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    4996b71 View commit details
    Browse the repository at this point in the history

  2. Convert JSTS Monkey import to side-effect import

    @mzur
    mzur committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    27a7055 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Remove unnecessary if-else condition

    @lehecht
    lehecht committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    86dfe03 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Fix bug with intersecting polygons after modification

    @lehecht
    lehecht committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    99758f2 View commit details
    Browse the repository at this point in the history

  2. Rename method to shorten name

    @lehecht
    lehecht committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bcefe6d View commit details
    Browse the repository at this point in the history

  3. Add comments

    @lehecht
    lehecht committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bdeb64c View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Add comments

    @lehecht
    lehecht committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f1e7730 View commit details
    Browse the repository at this point in the history

  2. Make code more readable

    @lehecht
    lehecht committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    86b5cea View commit details
    Browse the repository at this point in the history

  3. Add Polygon check after modifying video polygons

    @lehecht
    lehecht committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    7a340c6 View commit details
    Browse the repository at this point in the history

  4. Edit comments

    @lehecht
    lehecht committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    4fc7573 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Implement alternative handling of polygons with holes

    @mzur
    mzur committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9db8277 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Merge pull request #700 from biigle/non-simple-polygon-bug-patch-1 

    Implement alternative handling of polygons with holes
    @mzur
    mzur authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    fabfa21 View commit details
    Browse the repository at this point in the history