Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement video sprite generator #712

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Implement video sprite generator #712

merged 3 commits into from
Dec 11, 2023

Conversation

gkourie
Copy link
Contributor

@gkourie gkourie commented Nov 30, 2023

Add the function generateSprites which generates sprites from a video file, organizes them into a
5x5 sprite sheets. Related to #375

the function generateSprites generates sprites from a video file, organizes them into a
5x5 sprite sheet, and saves them.
@mzur mzur changed the base branch from master to video-sprites December 1, 2023 07:56
@mzur
Copy link
Member

mzur commented Dec 1, 2023

I have changed the target branch in biigle/core so we can merge the backend code in this pull request and then merge the frontend code in a second pull request. If the code of this pull request is ready for review, please click "request review" (from me) here at the top right of the pull request. I'll have a look at the code and add comments then.

@gkourie gkourie marked this pull request as draft December 2, 2023 19:27
@gkourie gkourie marked this pull request as ready for review December 2, 2023 19:45
@mzur mzur self-requested a review December 4, 2023 08:44
app/Jobs/ProcessNewVideo.php Outdated Show resolved Hide resolved
app/Jobs/ProcessNewVideo.php Outdated Show resolved Hide resolved
app/Jobs/ProcessNewVideo.php Outdated Show resolved Hide resolved
app/Jobs/ProcessNewVideo.php Outdated Show resolved Hide resolved
app/Jobs/ProcessNewVideo.php Outdated Show resolved Hide resolved
app/Jobs/ProcessNewVideo.php Outdated Show resolved Hide resolved
app/Jobs/ProcessNewVideo.php Outdated Show resolved Hide resolved
tests/php/Jobs/ProcessNewVideoTest.php Outdated Show resolved Hide resolved
tests/php/Jobs/ProcessNewVideoTest.php Outdated Show resolved Hide resolved
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There is only a variable naming issue and the reusable function that I didn't explain clearly enough before 😉 I hope now it's more clear, otherwise please ask.

app/Jobs/ProcessNewVideo.php Outdated Show resolved Hide resolved
app/Jobs/ProcessNewVideo.php Outdated Show resolved Hide resolved
app/Jobs/ProcessNewVideo.php Outdated Show resolved Hide resolved
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@mzur mzur merged commit d5211ed into biigle:video-sprites Dec 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants