Fix Vips thumbnails aspect ratio and implement thumbnail preview feature on the frontend #762

gkourie · 2024-01-27T18:49:42Z

Fixes an issue with the aspect ratio of Vips thumbnails buffer by setting the size to force (see issue-75).
Implements the thumbnail preview feature on the frontend.
Adjusts the corresponding test cases to reflect these changes.

Upgrade PHP dependencies

Co-authored-by: Martin Zurowietz <mzur@users.noreply.github.com>

Adapt core templates (master) to work with the geo module

The default database is now used as vector database, too. References biigle/maia#150

Remove separate vector database

Update volume validation

Set seeking on false again after loading video, because seek() is called everytime a video is loaded. Fixes biigle#695.

Fix active spinning wheel after video finished loading

Replace seeked event by timeupdate, because seeked event does not always reset time after switching videos. Fix biigle#724

Fix biigle#660

If single and clip annotations are linked and are not touching each other, then null is added. When deleting the single frame annotation, delete also the null. Fix biigle#488

Fixes biigle#718

References biigle#736

Add Dependabot config

Add libsvg to worker.dockerfile

With the new Dependabot config, the reqirements file in the root is no longer needed.

Largo sort

This commit fixes an issue with the aspect ratio of Vips thumbnails buffer by setting the size to 'force'. It also adjusts the corresponding test cases.

fix error on console command creating new user without admin rights

References biigle/reports#111

Add missing pandas requirement

mzur

Fantastic! Really well done 👏

I have a few minor comments (see below). These are the major points:

The preview thumbnail often briefly flashes before it repositions itself when the image is loaded or hides itself if the loading failed. Flashing with image:

Screencast.from.01.02.2024.16.01.41.webm

Flashing without image:

Screencast.from.01.02.2024.16.03.34.webm
The thumbnail does not show when I start at the left of the timeline. Once I cross some sort of threshold, it shows. Then I can move backwards again and it keeps showing (the correct images, too). I use Firefox if that matters.

Screencast.from.01.02.2024.16.02.40.webm
I was going to say that we have to take care of deleting the sprites when a video is deleted but luckily the existing code just deletes the whole directory. So nothing to do here 👍
Please add a paragraph to the manual that explains the new button.

That's it! After this is merged I will check the issue with ['size' => 'force'] and implement the console command to generate missing sprites.

app/Http/Controllers/Views/Videos/VideoController.php

resources/assets/js/videos/components/thumbnailPreview.vue

resources/assets/js/videos/main.js

mzur · 2024-02-01T15:39:58Z

Also can you please sync the dev-modules branch of your fork? Then the test-modules check should work, too.

gkourie · 2024-02-01T20:18:52Z

Also can you please sync the dev-modules branch of your fork? Then the test-modules check should work, too.

I did, but still not working.

mzur

Thanks! Looks even better now. One final thing came to my attention:

If the sprites do not exist, the thumbnail component sends an HTTP request basically on each mousemove event. Instead, I suggest that a) the component should try each URL only once or twice and then give up (it will try again if the mouse is moved away and then back again, creating the component anew) or b) try each URL only once each 10, 20 or 30 seconds.

mzur · 2024-02-02T14:03:04Z

Also can you please sync the dev-modules branch of your fork? Then the test-modules check should work, too.

I did, but still not working.

Sorry, it seems like master had to be synced instead. I did this now and the tests pass.

mzur

Thanks 👍

lehecht and others added 30 commits November 30, 2023 08:06

Add libsvg to worker.dockerfile

af0a9c2

Upgrade PHP dependencies

f47fbec

Fix precomputed password hashes in tests

48e2fb2

Fix ApiTokenFactory

c7c73c8

Merge pull request biigle#715 from biigle/patch-1

941f709

Upgrade PHP dependencies

create fileCount-method for the filters

a573b26

add an array-equality check in hasRule()

2651e11

handle null values in equalityCheck

5fb4d91

Apply code-linting from code review

4b2007e

Co-authored-by: Martin Zurowietz <mzur@users.noreply.github.com>

always show fileCount for filters

5cc56c7

modify name and structure of functions for better readability

31a3ac0

Update developing.md

1ef89da

split fileCount and dataName functions and add different style

1fa5370

remove unnecessary if-statement

6ff89d1

add return value for absent data-name

8915307

Merge pull request biigle#716 from biigle/geo_module

91ac92b

Adapt core templates (master) to work with the geo module

Remove separate vector database

5c248a7

The default database is now used as vector database, too. References biigle/maia#150

Fix CS issue

779564d

Merge pull request biigle#720 from biigle/merge-pgvector

9e18403

Remove separate vector database

Add length restriction to request URL

3a57428

Add test for invalid url

fdd75ee

Edit comment

5067d9f

Fix 'composer fix' errors

ded7660

Merge pull request biigle#722 from biigle/update-volume-validation

26e8618

Update volume validation

Fix active spinning wheel after video finished loading

a57b2e5

Set seeking on false again after loading video, because seek() is called everytime a video is loaded. Fixes biigle#695.

Merge pull request biigle#723 from biigle/spinning-wheel-bug

997328a

Fix active spinning wheel after video finished loading

Fix video timeline reset bug by using timeupdate event

ca35160

Replace seeked event by timeupdate, because seeked event does not always reset time after switching videos. Fix biigle#724

Check feature's availability before removing it

1c3d255

Fix biigle#660

Remove null (gap) to prevent validation errors

6d43aa8

If single and clip annotations are linked and are not touching each other, then null is added. When deleting the single frame annotation, delete also the null. Fix biigle#488

Fix flag display

c28bc69

Fixes biigle#718

mzur and others added 13 commits January 23, 2024 09:08

Update Pillow version in dockerfile

2133d4c

References biigle#736

Add Dependabot config

ef4a72c

Merge pull request biigle#737 from biigle/patch-1

7972b85

Add Dependabot config

Update dependabot config

c62ac9e

Implement AnnotationLabelAttached event

68659fe

Merge pull request biigle#711 from biigle/docker-workerfile

f87213a

Add libsvg to worker.dockerfile

Merge branch 'master' into largo-sim-sort

164395a

Update Python requirements specifications

5ce3bc9

With the new Dependabot config, the reqirements file in the root is no longer needed.

Merge branch 'master' into largo-sim-sort

3c310cc

Merge pull request biigle#730 from biigle/largo-sim-sort

ea69fc3

Largo sort

fix error on console command creating new user without admin rights

13641e4

Fix Vips thumbnails buffer aspect ratio issue.

bbea48c

This commit fixes an issue with the aspect ratio of Vips thumbnails buffer by setting the size to 'force'. It also adjusts the corresponding test cases.

Implement Thumbnail Preview feature on frontend

1b6c587

gkourie force-pushed the master branch from 21406f1 to 1b6c587 Compare January 30, 2024 00:06

mzur and others added 3 commits January 30, 2024 11:05

Merge pull request biigle#764 from ToukL/master

68d3d17

fix error on console command creating new user without admin rights

Add missing pandas requirement

731f01c

References biigle/reports#111

Merge pull request biigle#765 from biigle/patch-1

f547b9d

Add missing pandas requirement

mzur requested changes Feb 1, 2024

View reviewed changes

Fix issue with flashing thumbnail when sprite is not found

8d866b2

gkourie force-pushed the master branch from fd0d1a9 to 8d866b2 Compare February 1, 2024 20:08

mzur requested changes Feb 2, 2024

View reviewed changes

Add limit to sprite loading retry attempts

da6f0ea

gkourie force-pushed the master branch from 0c345ef to da6f0ea Compare February 4, 2024 18:14

Merge branch 'biigle:master' into master

1ad58de

gkourie requested a review from mzur February 4, 2024 18:22

mzur approved these changes Feb 16, 2024

View reviewed changes

mzur merged commit bcbb815 into biigle:video-sprites Feb 16, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Vips thumbnails aspect ratio and implement thumbnail preview feature on the frontend #762

Fix Vips thumbnails aspect ratio and implement thumbnail preview feature on the frontend #762

gkourie commented Jan 27, 2024

mzur left a comment

mzur commented Feb 1, 2024 •

edited

Loading

gkourie commented Feb 1, 2024

mzur left a comment

mzur commented Feb 2, 2024 •

edited

Loading

mzur left a comment

Fix Vips thumbnails aspect ratio and implement thumbnail preview feature on the frontend #762

Fix Vips thumbnails aspect ratio and implement thumbnail preview feature on the frontend #762

Conversation

gkourie commented Jan 27, 2024

mzur left a comment

Choose a reason for hiding this comment

mzur commented Feb 1, 2024 • edited Loading

gkourie commented Feb 1, 2024

mzur left a comment

Choose a reason for hiding this comment

mzur commented Feb 2, 2024 • edited Loading

mzur left a comment

Choose a reason for hiding this comment

mzur commented Feb 1, 2024 •

edited

Loading

mzur commented Feb 2, 2024 •

edited

Loading