Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to ensure filtering is finished #846

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Add button to ensure filtering is finished #846

merged 8 commits into from
Jun 21, 2024

Conversation

lehecht
Copy link
Contributor

@lehecht lehecht commented Jun 4, 2024

Closes #692.

Add a 'Test file query' button to enable volume cloning only after the filtering process is finished.

@lehecht lehecht requested a review from mzur June 4, 2024 07:41
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original idea has to be refined a bit, as the UX is currently not good:

  • Instead of replacing the "clone" button, the "test query" button should appear somewhere next to the query input field when "filter files" is checked. Perhaps you can find a solution that does not occupy too much additional space. The button should still be .btn-success.

  • When "filter files" is checked and the query is unchecked/dirty, the "clone" button should be disabled with a title saying that the query has to be checked first.

  • When "filter files" is unchecked, the "clone" button should be enabled again, even if the file query is unchecked/dirty.

  • When the file query is checked/ok, the "test query" button can disappear.

Enable volume cloning if file name query was checked.
@lehecht lehecht requested a review from mzur June 19, 2024 07:16
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move the "test query" button above the file pattern input field? It can still be .pull-right and maybe change it to .btn-xs. As it is now, it overflows to the checkboxes below and can sometimes not be clicked. Also, it's quite far away from the input and the relation is unclear.

Now if I initially click on "filter files", the "clone" button is still active. However, cloning with an empty file list should not be possible. Also if I enter a file pattern that turns up no files, the clone button should still be disabled.

If I change the file query but don't click on "test query", the clone button is correctly disabled. But if I now uncheck "filter files" and immediately check it again, the file pattern is still changed and does not match with the previous tested file list. Furthermore, the clone button is enabled now but it shouldn't, as there now is an untested file pattern.

resources/assets/js/volumes/cloneForm.vue Outdated Show resolved Hide resolved
@lehecht lehecht requested a review from mzur June 21, 2024 06:49
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've tweaked the button position and updated the clone button title texts one final time.

@mzur mzur merged commit 98a64c4 into master Jun 21, 2024
6 checks passed
@mzur mzur deleted the fix-file-filtering branch June 21, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix clone volume UI for filtering files
2 participants