Support string cookie values in rails test cases

[jcw-]

In Authlogic v6.2, a new method cookie_enabled? started exercising cookie code in test cases in a few more places than usual, resulting in existing test code in downstream projects that included cookies with string values (rather than hash values) to start failing with:

TypeError: no implicit conversion of Symbol into Integer

This PR adds support for both, using the same approach as Rails itself.

Before:

After:

[jaredbeck]

Hi @jcw- thanks for the contribution.

On one hand, this seems good because it makes RailsRequestAdapter#cookies act more like an actual rails request. For completeness, MockSignedCookieJar#[]= would also need this feature, right?

On the other hand, I don't think that RailsRequestAdapter is part of the public API of Authlogic. It's part of the test suite. It seems we're talking about adding a feature that Authlogic doesn't need, to Authlogic's private test suite. Can you talk a bit more about how "test code in downstream projects" use it, and why you think RailsRequestAdapter should be public API? Thanks.

[jcw-]

Hi @jaredbeck, thanks for the quick response - good point about the MockSignedCookieJar, I can look into that. Here's some more background about my intent:

After upgrading to 6.2, some of our specs started failing, they were specs that had this:

      before(:each) do
        request.cookies[:some_cookie] = "something"
      end

It didn't seem like RailsRequestAdapter -> cookies had any test coverage, so this was my attempt to surface it - I'm not intending to change anything from private to public. I was actually struggling a bit to write tests for that code, which has an entry point in activate_authlogic. Any tips on a better approach to get test coverage on that?

[jaredbeck]

Thanks for the clarification. I was able to reproduce the TypeError in a work project by setting a string cookie.

# spec/controllers/user_sessions_controller_spec.rb
   describe '#new' do
     it 'succeeds' do
+      request.cookies[:some_cookie] = "something"
       UserSession.create!(....) # TypeError

When I debug the issue, I arrive at the same solution you did.

Please disregard my confusion about public/private API.

Let's move forward with this, making sure that this feature (string cookies) is added consistently to all of our test classes. I think there's more than one place in test_case/mock_cookie_jar.rb, for example.

[jcw-]

@jaredbeck alright added support to the cookie jars, I'm not seeing anywhere else, let me know what you think...

[jaredbeck]

Released as 6.4.0