Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logstash rework #52

Merged
merged 25 commits into from
Nov 25, 2020
Merged

Logstash rework #52

merged 25 commits into from
Nov 25, 2020

Conversation

bharel
Copy link
Contributor

@bharel bharel commented Nov 22, 2020

Docs + Tests underway.

Looking for a review on the interface and if any changes are requested before I make this pretty.

Copy link
Contributor

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an function for clearing logs.

@aviramha
Copy link
Contributor

Add an API for accessing the records without the asserts and also I think you should provide a context manager for assert logs and assert no logs, similar to unittest.

yellowbox/extras/logstash.py Outdated Show resolved Hide resolved
yellowbox/extras/logstash.py Outdated Show resolved Hide resolved
yellowbox/extras/logstash.py Outdated Show resolved Hide resolved
yellowbox/extras/logstash.py Outdated Show resolved Hide resolved
yellowbox/extras/logstash.py Outdated Show resolved Hide resolved
yellowbox/extras/logstash.py Show resolved Hide resolved
yellowbox/extras/logstash.py Show resolved Hide resolved
yellowbox/utils.py Outdated Show resolved Hide resolved
yellowbox/utils.py Outdated Show resolved Hide resolved
yellowbox/extras/logstash.py Outdated Show resolved Hide resolved
yellowbox/extras/logstash.py Show resolved Hide resolved
yellowbox/extras/logstash.py Outdated Show resolved Hide resolved
yellowbox/extras/logstash.py Outdated Show resolved Hide resolved
yellowbox/extras/logstash.py Outdated Show resolved Hide resolved
yellowbox/extras/logstash.py Show resolved Hide resolved
yellowbox/extras/logstash.py Outdated Show resolved Hide resolved
bharel and others added 3 commits November 24, 2020 18:09
Co-authored-by: Ben Avrahami <ben.avrahami@biocatch.com>
tests/extras/test_logstash.py Outdated Show resolved Hide resolved
tests/extras/test_logstash.py Show resolved Hide resolved
tests/extras/test_logstash.py Show resolved Hide resolved
yellowbox/extras/logstash.py Outdated Show resolved Hide resolved
yellowbox/extras/logstash.py Show resolved Hide resolved
bharel and others added 9 commits November 25, 2020 16:40
Co-authored-by: Ben Avrahami <ben.avrahami@biocatch.com>
Co-authored-by: Ben Avrahami <ben.avrahami@biocatch.com>
@bharel bharel self-assigned this Nov 25, 2020
@bharel bharel requested a review from aviramha November 25, 2020 16:07
@bharel bharel marked this pull request as ready for review November 25, 2020 16:08
@bharel bharel removed the request for review from aviramha November 25, 2020 16:08
Copy link
Contributor

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #52 (1832c9f) into master (ed9b5ff) will increase coverage by 0.43%.
The diff coverage is 91.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   87.89%   88.33%   +0.43%     
==========================================
  Files          13       13              
  Lines         694      797     +103     
  Branches       64       78      +14     
==========================================
+ Hits          610      704      +94     
- Misses         58       65       +7     
- Partials       26       28       +2     
Flag Coverage Δ
unittests 88.33% <91.36%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
yellowbox/subclasses.py 84.50% <ø> (ø)
yellowbox/utils.py 82.75% <66.66%> (-5.25%) ⬇️
yellowbox/extras/logstash.py 91.45% <91.45%> (-2.30%) ⬇️
yellowbox/extras/http_server.py 99.28% <100.00%> (+1.38%) ⬆️
yellowbox/extras/rabbit_mq.py 89.33% <100.00%> (ø)
yellowbox/service.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9b5ff...1832c9f. Read the comment docs.

@bharel bharel merged commit 09306e4 into master Nov 25, 2020
@bharel bharel deleted the logstash-rework branch November 25, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants