Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: apply style black, flake8, isort (#108) #109

Closed
wants to merge 2 commits into from

Conversation

holtgrewe
Copy link
Contributor

Also includes this as a check in CI.

@holtgrewe
Copy link
Contributor Author

holtgrewe commented May 4, 2023

This should be merged after #107 as it patches the GitHub workflow file.

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Sep 18, 2023
@reece
Copy link
Member

reece commented Sep 19, 2023

@holtgrewe Thanks for this contribution. All packages are conceptually derived from the biocommons.example template. That's where formatting, packaging, ci/cd, and other boilerplate config starts.

At the recent hackathon, we made big strides in all of these areas and have started to pull them into code repos.

I'm going to close this PR. Thanks again.

@reece reece closed this Sep 19, 2023
@reece reece added stale closed Issue was closed automatically due to inactivity and removed stale closed Issue was closed automatically due to inactivity labels Nov 27, 2023
@reece reece added this to the 0.7 milestone Nov 27, 2023
@reece reece reopened this Nov 27, 2023
@reece reece self-requested a review as a code owner November 27, 2023 04:48
@reece reece removed the stale Issue is stale and subject to automatic closing label Nov 27, 2023
@jsstevenson
Copy link
Contributor

I wound up replicating some of this work in #141 in conjunction with pulling in elements from the biocommons template -- consequently, I think this PR can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants