112 make fastadir thread safe #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
stale
|
@reece, what is the status of this PR? Are you waiting for action from @theferrit32 here? |
theferrit32
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@theferrit32 @davmlaw @andreasprlic @ahwagner @jsstevenson
Before merging a fix for #112, I want to make sure that we can reproduce it and understand it.
In my opinion, the problem is not related to threading (as surmised in the original problem report), but is more directly attributable to file descriptor exhaustion and the difficulty in handling that gracefully. See misc/threading-tests/README.md in this PR for some demonstration cases.
My current inclination is to disable caching since that's the safest mode, and then work on reincorporating caching in a subsequent PR.