Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: finish migrating from setup.cfg to pyproject.toml in order to install seqrepo cli #139

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

reece
Copy link
Member

@reece reece commented Feb 19, 2024

See #138 for explanation.

@biocommons/maintainers : To test, please pull this branch and make devready then try seqrepo. If that works, I think we're good to go.

@reece reece requested a review from a team as a code owner February 19, 2024 21:07
@reece reece linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble running make devready on a Mac:

make venv && source venv/bin/activate && make develop
/bin/bash: line 0: globstar: invalid shell option name
make: *** [devready] Error 2

Changing: SHELL:=/bin/bash -e -o pipefail -O globstar to SHELL:=/bin/bash -e -o pipefail gets make devready to work.

I then run source venv/bin/activate. After running seqrepo, I get:

Traceback (most recent call last):
  File "/Users/kxk102/Documents/biocommons/biocommons.seqrepo/venv/bin/seqrepo", line 5, in <module>
    from biocommons.seqrepo.cli import main
  File "/Users/kxk102/Documents/biocommons/biocommons.seqrepo/src/biocommons/seqrepo/cli.py", line 34, in <module>
    import tqdm
ModuleNotFoundError: No module named 'tqdm'

We'll want to update the develop in Makefile to pip install -e .[dev,docs,loading].

After these changes, I can successfully run seqrepo.

@reece
Copy link
Member Author

reece commented Feb 20, 2024

I removed the loading optional deps (it was new) and put its deps in dev.

I also added instructions for Mac OSX, which includes installing bash. (Although the makefile appeared to work for you, the clean targets that use globstar would fail. globstar needs to stay.

@korikuzma Would you please try again?

Copy link

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm those changes work! Thanks @reece

@reece reece merged commit 344d9d6 into main Feb 20, 2024
7 checks passed
@reece reece deleted the 138-seqrepo-cli-not-installed-in-066-and-067 branch February 20, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seqrepo cli not installed in 0.6.6 and 0.6.7
2 participants