Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve type errors/add type annotations #151

Merged
merged 5 commits into from
May 30, 2024
Merged

fix: resolve type errors/add type annotations #151

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e77f3a5
add types
jsstevenson May 27, 2024
1454684
don't add this
jsstevenson May 27, 2024
dddd953
add exit types
jsstevenson May 29, 2024
4889135
store_alias shouldn't have a None alias
jsstevenson May 29, 2024
844fbae
make final change
jsstevenson May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add exit types
  • Loading branch information
@jsstevenson
jsstevenson committed May 29, 2024
commit dddd953e031743f27bd29b584e1e4928495a9470
5 changes: 3 additions & 2 deletions src/biocommons/seqrepo/_internal/logging_support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import logging
from typing import Optional
from types import TracebackType
from typing import Optional, Type


class DuplicateFilter:
Expand All @@ -26,6 +27,6 @@ def __enter__(self):
)
self.logger.addFilter(self)

def __exit__(self, exc_type, exc_val, exc_tb):
def __exit__(self, exc_type: Type[Exception], exc_value: Exception, traceback: TracebackType):
if self.logger is not None:
self.logger.removeFilter(self)
Loading