Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite usage is changed to more Python DB API 2.0 compatible. #63

Merged
merged 3 commits into from
Jul 22, 2019

Conversation

teemuvesala
Copy link
Contributor

This enables the possibility to use another SQL database for backend.

teemuvesala and others added 3 commits July 3, 2019 07:45
…ables the possibility to use another SQL database for backend.
…rating system is. The exception is still same anyway and it's checked at with-part
@coveralls
Copy link

coveralls commented Jul 22, 2019

Pull Request Test Coverage Report for Build 228

  • 33 of 38 (86.84%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 93.45%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/biocommons/seqrepo/seqaliasdb/seqaliasdb.py 19 20 95.0%
src/biocommons/seqrepo/fastadir/fastadir.py 14 18 77.78%
Totals Coverage Status
Change from base Build 227: -0.4%
Covered Lines: 428
Relevant Lines: 458

💛 - Coveralls

@reece reece merged commit 23dec48 into biocommons:master Jul 22, 2019
@reece
Copy link
Member

reece commented Jul 22, 2019

@teemuvesala Thanks very much for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants