Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: format with Ruff #25

Merged
merged 3 commits into from
Jun 21, 2024
Merged

style: format with Ruff #25

merged 3 commits into from
Jun 21, 2024

Conversation

jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Jun 5, 2024

Replace black with ruff for formatting.

@jsstevenson jsstevenson marked this pull request as ready for review June 18, 2024 11:59
@jsstevenson jsstevenson requested a review from a team as a code owner June 18, 2024 11:59
@@ -4,42 +4,27 @@ on:
push:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a general comment. I think we might want to check that GH action workflows are consistent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh, virtually every element of the biocommons template is inconsistent across the repos... not really sure if the best principle is to try to standardize all at once or move iteratively.

pyproject.toml Outdated
@@ -128,3 +125,8 @@ disable = "R0913"

[tool.pylint.format]
max-line-length = 100

[tool.ruff]
src = ["src", "test"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src = ["src", "test"]
src = ["src", "tests"]

@jsstevenson jsstevenson merged commit 2b56cd4 into main Jun 21, 2024
8 checks passed
@jsstevenson jsstevenson deleted the ruff-format branch June 21, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants