Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verkko to v1.0 release #34374

Merged
merged 17 commits into from
Apr 21, 2022
Merged

Update verkko to v1.0 release #34374

merged 17 commits into from
Apr 21, 2022

Conversation

skoren
Copy link
Contributor

@skoren skoren commented Apr 19, 2022

Updated verkko to v1.0 release. Added rust dependency and updated snakemake version. Also added OS X compatibility.

@skoren
Copy link
Contributor Author

skoren commented Apr 19, 2022

@bioconda/core I'm getting rust errors in the OS X test but this runs fine on my local OS X machine. I think it might be a network connectivity issue or a rust configuration issue in the CI node:

2022-04-19T15:56:09.3490640Z INFO:bioconda_utils.utils:(ERR)   Downloaded atty v0.2.14
2022-04-19T15:56:09.3492520Z 15:56:09 BIOCONDA INFO (ERR)   Downloaded atty v0.2.14
2022-04-19T15:56:09.3597410Z INFO:bioconda_utils.utils:(ERR) thread 'main' panicked at '`UNKNOWN/.cargo/registry/src/github.com-1ecc6299db9ec823/atty-0.2.14/UNKNOWN/.cargo/registry/src/github.com-1ecc6299db9ec823/atty-0.2.14/src/lib.rs` is not absolute', src/tools/cargo/src/cargo/core/manifest.rs:252:9
2022-04-19T15:56:09.3600300Z 15:56:09 BIOCONDA INFO (ERR) thread 'main' panicked at '`UNKNOWN/.cargo/registry/src/github.com-1ecc6299db9ec823/atty-0.2.14/UNKNOWN/.cargo/registry/src/github.com-1ecc6299db9ec823/atty-0.2.14/src/lib.rs` is not absolute', src/tools/cargo/src/cargo/core/manifest.rs:252:9

The url looks very strange and isn't in our repo anywhere.

@BiocondaBot
Copy link
Collaborator

Reposting for @skoren to enable pings (courtesy of the BiocondaBot):

@bioconda/core I'm getting rust errors in the OS X test but this runs fine on my local OS X machine. I think it might be a network connectivity issue or a rust configuration issue in the CI node:

2022-04-19T15:56:09.3490640Z INFO:bioconda_utils.utils:(ERR)   Downloaded atty v0.2.14
2022-04-19T15:56:09.3492520Z 15:56:09 BIOCONDA INFO (ERR)   Downloaded atty v0.2.14
2022-04-19T15:56:09.3597410Z INFO:bioconda_utils.utils:(ERR) thread 'main' panicked at '`UNKNOWN/.cargo/registry/src/github.com-1ecc6299db9ec823/atty-0.2.14/UNKNOWN/.cargo/registry/src/github.com-1ecc6299db9ec823/atty-0.2.14/src/lib.rs` is not absolute', src/tools/cargo/src/cargo/core/manifest.rs:252:9
2022-04-19T15:56:09.3600300Z 15:56:09 BIOCONDA INFO (ERR) thread 'main' panicked at '`UNKNOWN/.cargo/registry/src/github.com-1ecc6299db9ec823/atty-0.2.14/UNKNOWN/.cargo/registry/src/github.com-1ecc6299db9ec823/atty-0.2.14/src/lib.rs` is not absolute', src/tools/cargo/src/cargo/core/manifest.rs:252:9

The url looks very strange and isn't in our repo anywhere.

@dpryan79
Copy link
Contributor

I expect the failure is specific to the CI system since I see a nice big UNKNOWN in the path of the missing file. Can you skip that test and then install the package locally for testing?

@skoren
Copy link
Contributor Author

skoren commented Apr 20, 2022

Wouldn't skipping the test skip it on user systems too? That wouldn't be ideal to confirm the installation worked. I think the issue is the same as I had in the build script before, namely $HOME is undefined on Darwin (or rather UNKNOWN) so any tools that use the home folder like rust or snakemake fail. Adding this:

# taken from yacrd recipe, see: https://github.com/bioconda/bioconda-recipes/blob/2b02c3db6400499d910bc5f297d23cb20c9db4f8/recipes/yacrd/build.sh
 if [ "$(uname)" == "Darwin" ]; then

     # apparently the HOME variable isn't set correctly, and circle ci output indicates the following as the home directory
     export HOME=`pwd`
     echo "HOME is $HOME"
     mkdir -p $HOME/.cargo/registry/index/
 fi

seems to have fixed the build on Darwin so I'll try to see if it fixes the test as well. If not, I'll turn off the test on Darwin and return success so it's CI compliant.

@skoren
Copy link
Contributor Author

skoren commented Apr 20, 2022

@dpryan79, that was the issue, $HOME has to be defined in all shell scripts in OS X it seems. Maybe this could be done in a central bioconda script that runs on CI startup so all the recipes don't have to do it manually?

@skoren
Copy link
Contributor Author

skoren commented Apr 20, 2022

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built on Azure are ready for inspection:

Arch Package Zip File
linux-64 verkko-1.0-h64afbab_3.tar.bz2 LinuxArtifacts
osx-64 verkko-1.0-hf7549e5_3.tar.bz2 OSXArtifacts

You may also use conda to install these after downloading and extracting the appropriate zip file. From the LinuxArtifacts or OSXArtifacts directories:

conda install -c packages <package name>

Docker image(s) built (images are in the LinuxArtifacts zip file above):

Package Tag Install with docker
verkko 1.0--h64afbab_3
showgzip -dc LinuxArtifacts/images/verkko:1.0--h64afbab_3.tar.gz | docker load

@skoren
Copy link
Contributor Author

skoren commented Apr 20, 2022

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Apr 20, 2022
@dpryan79
Copy link
Contributor

Tests aren't run on user systems, the compiled packages are directly extracted and the resulting binaries immediately used. I should modify the CI to set $HOME on OSX now that you mention it.

@dpryan79
Copy link
Contributor

Ah, so HOME isn't one of the variables we re-export into environments it seems. I need to look into this, since then we wouldn't need to rely on zsh setting it on CI providers.

@dpryan79
Copy link
Contributor

@BiocondaBot please merge

I'll work on fixing the $HOME thing over in the bioconda-utils repo.

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot BiocondaBot merged commit 1d0f441 into bioconda:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants