-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update verkko to v1.0 release #34374
Conversation
@bioconda/core I'm getting rust errors in the OS X test but this runs fine on my local OS X machine. I think it might be a network connectivity issue or a rust configuration issue in the CI node:
The url looks very strange and isn't in our repo anywhere. |
Reposting for @skoren to enable pings (courtesy of the BiocondaBot):
The url looks very strange and isn't in our repo anywhere. |
I expect the failure is specific to the CI system since I see a nice big UNKNOWN in the path of the missing file. Can you skip that test and then install the package locally for testing? |
Wouldn't skipping the test skip it on user systems too? That wouldn't be ideal to confirm the installation worked. I think the issue is the same as I had in the build script before, namely $HOME is undefined on Darwin (or rather UNKNOWN) so any tools that use the home folder like rust or snakemake fail. Adding this:
seems to have fixed the build on Darwin so I'll try to see if it fixes the test as well. If not, I'll turn off the test on Darwin and return success so it's CI compliant. |
@dpryan79, that was the issue, $HOME has to be defined in all shell scripts in OS X it seems. Maybe this could be done in a central bioconda script that runs on CI startup so all the recipes don't have to do it manually? |
@BiocondaBot please fetch artifacts |
Package(s) built on Azure are ready for inspection:
You may also use
Docker image(s) built (images are in the LinuxArtifacts zip file above):
|
@BiocondaBot please add label |
Tests aren't run on user systems, the compiled packages are directly extracted and the resulting binaries immediately used. I should modify the CI to set $HOME on OSX now that you mention it. |
Ah, so HOME isn't one of the variables we re-export into environments it seems. I need to look into this, since then we wouldn't need to rely on zsh setting it on CI providers. |
@BiocondaBot please merge I'll work on fixing the $HOME thing over in the bioconda-utils repo. |
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
Updated verkko to v1.0 release. Added rust dependency and updated snakemake version. Also added OS X compatibility.