Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk unindexing for IndexerInterface #598

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

Bulk unindexing for IndexerInterface #598

wants to merge 13 commits into from

Commits on Apr 17, 2024

  1. [sdk] Add IndexerInterface::unindex(Collection<URI>) 

    - for unindexing in bulk
- clarify that both unindex methods are synchronous,
  unlike the indexing ones
    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e6a23a2 View commit details
    Browse the repository at this point in the history

  2. [sdk] Revamp IndexerInterface documentation 

    - adjust the content to align with good practices
  (see also https://bioinformatics-ua.github.io/dicoogle-learning-pack/docs/query_index/)
    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f1e1762 View commit details
    Browse the repository at this point in the history

  3. [sdk] rethink bulk unindexing to be more informative 

    - add `UnindexReport` class and nested classes
   - for containing errors which may occur in bulk unindexing
- change `IndexerInterface#unindex(Collection<URI>)`
   - returns `UnindexReport`
   - can throw `IOException`
    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8b7cb75 View commit details
    Browse the repository at this point in the history

  4. [sdk] reiterate on IndexerInterface batch unindex 

    - make it asynchronous: returns a `Task` like in `index`
- add second parameter for keeping track of progress
    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    76493aa View commit details
    Browse the repository at this point in the history

  5. [sdk] format UnindexReport

    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4c99599 View commit details
    Browse the repository at this point in the history

  6. [sdk] Improve bulk IndexerInterface#unindex 

    - clarify that it returns a task
- remove unused import
    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0c067e2 View commit details
    Browse the repository at this point in the history

  7. [sdk] Add UnindexReport#errorCount

    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    680c154 View commit details
    Browse the repository at this point in the history

  8. Add bulk unindexing to plugin controller 

    - can only handle one indexer at a time,
  but other than that it works
    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    38d7640 View commit details
    Browse the repository at this point in the history

  9. Tweak PluginController 

    - remove deprecated method call #handles,
  check scheme instead
    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    483f814 View commit details
    Browse the repository at this point in the history

  10. Update unindex servlet to use bulk unindexing where appropriate

    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1b99804 View commit details
    Browse the repository at this point in the history

  11. [core] Dispatch batch-unindex tasks

    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    70ce1b0 View commit details
    Browse the repository at this point in the history

  12. [sdk] Reiterate on the UnindexReport API 

    - record a collection of URIs in each unindex failure
    @Enet4
    Enet4 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    216b11f View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. [sdk] Tweak UnindexReport interface and fix error file count 

    - provide clearer methods to collect the counts
  of files which were not unindexed successfully
    @Enet4
    Enet4 committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    471566c View commit details
    Browse the repository at this point in the history