Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maven plugins #669

Merged
merged 4 commits into from
Oct 7, 2023
Merged

Update Maven plugins #669

merged 4 commits into from
Oct 7, 2023

Conversation

Enet4
Copy link
Collaborator

@Enet4 Enet4 commented Sep 30, 2023

This should be a safe maintenance update that does not affect functionality.

  • [dicoogle][sdk] Update maven plugins
    • maven-compiler-plugin 3.11.0
    • maven-shade-plugin 3.5.1
    • maven-resources-plugin 3.3.1
    • frontend-maven-plugin 1.14.0
      • update nodeVersion to 18.17.1 and npmVersion to 9.6.7
    • license-maven-plugin 4.3
    • formatter-maven-plugin 2.16.0
      • This is the only plugin I could not update to the latest version, because we want to continue supporting Java 8
  • Format Java code
  • Reorganize .gitignore
    • Add /target, remove obsolete lines, rearrange lines

- maven-compiler-plugin 3.11.0
- maven-shade-plugin 3.5.1
- maven-resources-plugin 3.3.1
- frontend-maven-plugin 1.14.0
   - update nodeVersion to 18.17.1 and npmVersion to 9.6.7
- license-maven-plugin 4.3
- formatter-maven-plugin 2.12.2
- 2.16.0
   - subsequent versions are not supported by Java 8
- Configure line endings to KEEP
- dicoogle and sdk, some code was not formatted
@Enet4 Enet4 added the chores label Sep 30, 2023
@Enet4 Enet4 self-assigned this Sep 30, 2023
@Enet4 Enet4 requested a review from bastiao October 2, 2023 08:37
Copy link
Member

@bastiao bastiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastiao bastiao merged commit 15549c3 into dev Oct 7, 2023
2 checks passed
@bastiao bastiao deleted the imp/maven-plugins-update branch October 7, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants