Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bcrypt dependency and password hash service #670

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Update Bcrypt dependency and password hash service #670

merged 2 commits into from
Oct 7, 2023

Conversation

Enet4
Copy link
Collaborator

@Enet4 Enet4 commented Sep 30, 2023

Summary

  • Update bcrypt and password hashing
    • bcrypt 0.10.2
    • Make password hashing strength configurable via JVM variable (default stays at 10)
  • Fix HashService for very large passwords
    • Set BCrypt version to 2B
    • Apply existing long password strategy in verification
    • Add HashServiceTest

@Enet4
Update bcrypt and password hashing
f9e14ed 
- update bcrypt dependency to
- make hashing strength configurable via JVM variable
@Enet4
Fix HashService for very large passwords
68b7cb0 
- Use BCrypt version 2B
- Apply long password strategy when verifying them
- Add HashServiceTest
@Enet4 Enet4 self-assigned this Sep 30, 2023
@Enet4 Enet4 requested a review from bastiao October 2, 2023 08:37
@bastiao bastiao merged commit 67c7209 into dev Oct 7, 2023
2 checks passed
@bastiao bastiao deleted the imp/update-bcrypt branch October 7, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastiao bastiao bastiao approved these changes

Assignees

@Enet4 Enet4

Labels
dicoogle-core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enet4 @bastiao