-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient boosting - Adapt tests to version xgboost=2; move xgboost/catboost to regular requirements #6570
Conversation
fad3f02
to
4e7571c
Compare
|
Oh, I now see there were just the tests. |
@markotoplak, no need for 3.36.1. It breaks only tests. I decided to fix it to xgboost>=2 since it doesn't hurt. If we don't want to do this, we will need to write two versions of tests. |
Can you also update meta.yaml? Conda-forge only has xgboost 1.7 for now, but that is likely not much of a problem. Anything that relies on building Orange though |
df1ec82
to
d6a6b95
Compare
I updated meta.yaml. I didn't fix the version there. I think it should work for now. |
110136a
to
c5a8ff4
Compare
c5a8ff4
to
5c22058
Compare
5c22058
to
68b5d5f
Compare
Issue
Xgboost released version 2.0.0, which changes some internal interfaces and breaks our tests.
Description of changes
Adapt tests to 2.0.0.
Also, now Xgboost packs Libomp in wheels for Macos (I think it was a primary reason for keeping Xgbosot and Catboost optional dependency). I suggest including both as a mandatory dependency. They are packed in Installers and part of a conda-forge package already/anyway.
Includes