BIP 0174: Clarify use of PSBT_IN_FINAL_* when data is empty #1221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clarification on how PSBT_IN_FINAL_SCRIPTSIG and PSBT_IN_FINAL_SCRIPTWITNESS should be handled when the data is empty. Based on feedback from @achow101 on twitter https://twitter.com/kallerosenbaum/status/1443856371368271872
It seems more people than I had interpreted the bip like you should always set PSBT_IN_FINAL_* even if data is empty, but @achow101 says we should leave those unset.