Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP-158: Fix description of M parameter #1411

Merged
merged 1 commit into from
May 8, 2024

Conversation

john-moffett
Copy link
Contributor

The M parameter is used as the inverse of the false probability rate, so change its incorrect usage in two places.

The M parameter is used as the inverse of the false probability rate, so change its incorrect usage in two places.
@john-moffett john-moffett changed the title Fix description of M parameter BIP-158: Fix description of M parameter Jan 31, 2023
@luke-jr
Copy link
Member

luke-jr commented Jun 29, 2023

@Roasbeef @aakselrod

@murchandamus
Copy link
Contributor

@aakselrod and/or @Roasbeef: could you take a look here?

@murchandamus murchandamus added the Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified label May 8, 2024
Copy link
Contributor

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥕

@Roasbeef Roasbeef merged commit 18956f1 into bitcoin:master May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified Proposed BIP modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants