NFKD normalize BIP39 spanish word list #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voisine
changed the title
|
This should also be done for Chinese... I assume you're going through the languages and checking? or would you like me to make a few pull requests as well? |
|
I checked. They look good, but it would be great if you can double check my work. |
|
Double checked, both simplified and traditional give the same hash before and after running through NFKD. |
|
@laanwj PR by BIP author. Please merge. Thanks. |
laanwj
added a commit
that referenced
this pull request
May 21, 2015
NFKD normalize BIP39 spanish word list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIP39 specifies that word lists must be Unicode NFKD normalized. This should not affect existing wallet seeds since they must be NFKD normalized prior to deriving a master private key.