Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP39: fix grammar in wordlists doc #1626

Merged
merged 16 commits into from
Jun 25, 2024
Merged

Conversation

nnsW3
Copy link
Contributor

@nnsW3 nnsW3 commented Jun 25, 2024

Rectify typographical inaccuracies.

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's worth changing BIPs that are final or withdrawn.

bip-0001.mediawiki Outdated Show resolved Hide resolved
bip-0039/bip-0039-wordlists.md Show resolved Hide resolved
@nnsW3
Copy link
Contributor Author

nnsW3 commented Jun 25, 2024

Do you want me to let the other as they were?

@jonatack
Copy link
Member

Do you want me to let the other as they were?

Yes, suggest keeping only the changes in the wordlist file.

@nnsW3
Copy link
Contributor Author

nnsW3 commented Jun 25, 2024

done sir

@jonatack jonatack changed the title Docs improvements BIP39: fix grammar in wordlists doc Jun 25, 2024
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jonatack jonatack merged commit 3d299b4 into bitcoin:master Jun 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants