Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP 84: Derivation scheme for P2WPKH based accounts #620

Merged
merged 1 commit into from
Dec 31, 2017
Merged

BIP 84: Derivation scheme for P2WPKH based accounts #620

merged 1 commit into from
Dec 31, 2017

Conversation

prusnak
Copy link
Contributor

@prusnak prusnak commented Dec 28, 2017

No description provided.

@luke-jr
Copy link
Member

luke-jr commented Dec 28, 2017

Please choose an acceptable copyright license.

@prusnak
Copy link
Contributor Author

prusnak commented Dec 28, 2017 via email

@luke-jr
Copy link
Member

luke-jr commented Dec 29, 2017

Let's go with 84.

@erasmospunk
Copy link
Contributor

Looks good.

@luke-jr luke-jr changed the title BIP-xxxx: Derivation scheme for P2WPKH based accounts BIP 84: Derivation scheme for P2WPKH based accounts Dec 29, 2017
@karelbilek
Copy link

I have fixed, squashed and force-pushed the mediawiki issue that made github to render the whole thing twice :)

@luke-jr
Copy link
Member

luke-jr commented Dec 29, 2017

README needs an update

m / purpose' / coin_type' / account' / change / address_index
</pre>

For the `purpose`-path level it uses `84'`. The rest of the levels are used as defined in BIP44 or BIP49.
Copy link
Contributor

@clarkmoody clarkmoody Dec 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MediaWiki format uses <code>some_code</code> for inline code samples.

@prusnak
Copy link
Contributor Author

prusnak commented Dec 31, 2017

Updated README, fixed inline code syntax.

@luke-jr luke-jr merged commit 38a7545 into bitcoin:master Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants