Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP32: Disambiguate Which Key Is Compromised When Ext. PubKey + PrivKey Are Leaked #64

Merged
merged 1 commit into from
Oct 15, 2014

Conversation

harding
Copy link
Contributor

@harding harding commented May 20, 2014

I mistakenly inferred from the following clause that a parent extended public key plus a child private key would be equivalent to knowing the extended child private key---meaning that the parent private key was still secure:

knowledge of the extended public key + any non-hardened private key descending from it is equivalent to knowing the extended private key

This patch's addition of the word "parent" (twice) removes the ambiguity and may help other readers draw the correct inference that the parent private key is no longer secure in this case.

I also changed "+" to "plus" to avoid confusion with the actual mathematical operations used in this BIP.

…Leaked

I mistakenly inferred from the following clause that a parent extended
public key plus a child private key would be equivalent to knowing the
extended *child* private key---meaning that the *parent* private key was
still secure:

> knowledge of the extended public key + any non-hardened private key
> descending from it is equivalent to knowing the extended private key

This patch's addition of the word "parent" (twice) removes the ambiguity
and may help other readers draw the correct inference that the parent
private key is no longer secure in this case.

I also changed "+" to "plus" to avoid confusion with the actual
mathematical operations used in this BIP.
@harding
Copy link
Contributor Author

harding commented May 20, 2014

I just took a look at other issues with BIPs---which I should've done first (sorry)---and discovered that #62 mentions the same issue.

@laanwj
Copy link
Member

laanwj commented Oct 15, 2014

As author of BIP32, @sipa can you comment on this change?

@sipa
Copy link
Member

sipa commented Oct 15, 2014

ACK

laanwj added a commit that referenced this pull request Oct 15, 2014
BIP32: Disambiguate Which Key Is Compromised When Ext. PubKey + PrivKey Are Leaked
@laanwj laanwj merged commit 1ce8320 into bitcoin:master Oct 15, 2014
jachiang pushed a commit to jachiang/bips that referenced this pull request Sep 16, 2019
Add a footnote about 32-byte security
real-or-random pushed a commit to real-or-random/bips that referenced this pull request Feb 23, 2023
Make naming of nonce variants R in mediawiki and code consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants