Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Column() filter and Visitors example #11

Merged
merged 12 commits into from
Jul 3, 2019
Merged

Add Column() filter and Visitors example #11

merged 12 commits into from
Jul 3, 2019

Conversation

bitfield
Copy link
Owner

@bitfield bitfield commented Jul 1, 2019 •
edited
Loading

Finishing touches needed for #7.

@bitfield bitfield mentioned this pull request Jul 1, 2019
Closed
breml
breml reviewed Jul 1, 2019
View reviewed changes
Copy link

@breml breml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all this looks good, just added some comments for you to consider.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/visitors/main.go Show resolved Hide resolved
filters.go Outdated Show resolved Hide resolved
filters.go Show resolved Hide resolved
filters.go Outdated Show resolved Hide resolved
testdata/column.input.txt Show resolved Hide resolved
@bitfield bitfield merged commit aa865a3 into master Jul 3, 2019
@bitfield bitfield deleted the column branch July 3, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breml breml breml left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitfield @breml