Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/mxnet] Add tests and publishing using VIB #12693

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Conversation

joancafom
Copy link
Contributor

@joancafom joancafom commented Sep 27, 2022

Description of the change

The main objective of this PR is to publish our Bitnami MXNet Helm Chart using VMware Image Builder. In order to do that, several changes are included:

  • Adding the asset to the publishing workflow
  • Increasing the existing test coverage of the asset by adding GOSS tests.

Benefits

  • Ensuring higher quality of the Helm charts.
  • Increased pool of assets completely handled by VMware Image Builder.

Possible drawbacks

Automated tests could show to be potentially flaky.

Applicable issues

NA

Additional information

Tested in joancafom#84

Checklist

Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Sep 27, 2022
@joancafom joancafom requested review from agomezmoron and FraPazGal and removed request for migruiz4 September 27, 2022 09:04
@joancafom joancafom assigned agomezmoron and FraPazGal and unassigned migruiz4 Sep 27, 2022
Copy link
Contributor

@FraPazGal FraPazGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @joancafom!

@joancafom joancafom merged commit 0af200e into master Sep 29, 2022
@joancafom joancafom deleted the add-mxnet-tests branch September 29, 2022 15:27
ashish-amarnath pushed a commit to ashish-amarnath/bitnami-charts that referenced this pull request Oct 11, 2022
* [bitnami/mxnet] Add tests

Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>

* Publish mxnet using VIB

Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>

Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants