Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/nats] Add support for service.headless.annotations #15437

Merged
merged 3 commits into from
Mar 21, 2023
Merged

[bitnami/nats] Add support for service.headless.annotations #15437

merged 3 commits into from
Mar 21, 2023

Conversation

migruiz4
Copy link
Member

Description of the change

Add support for the value service.headless.annotations.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@migruiz4
[bitnami/nats] Add support for service.headless.annotations
56baf4c 
Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
@github-actions github-actions bot added the nats label Mar 10, 2023
@bitnami-bot
Update README.md with readme-generator-for-helm
6005e18 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Mar 10, 2023
corico44
corico44 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@corico44 corico44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migruiz4
Merge branch 'main' into headless-annotations-nats
68b5451 
Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
@migruiz4 migruiz4 merged commit 5937c6d into main Mar 21, 2023
@migruiz4 migruiz4 deleted the headless-annotations-nats branch March 21, 2023 16:13
aoterolorenzo pushed a commit that referenced this pull request Mar 23, 2023
@migruiz4 @bitnami-bot @aoterolorenzo
[bitnami/nats] Add support for service.headless.annotations (#15437)
170ec4a 
* [bitnami/nats] Add support for service.headless.annotations

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

* Update README.md with readme-generator-for-helm

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corico44 corico44 corico44 approved these changes

Assignees

@corico44 corico44

Labels
bitnami nats solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@migruiz4 @corico44 @bitnami-bot