-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/*] Migrate VIB's runtime_params to independent file #15510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FraPazGal <fdepaz@vmware.com>
Signed-off-by: FraPazGal <fdepaz@vmware.com>
Signed-off-by: FraPazGal <fdepaz@vmware.com>
joancafom
reviewed
Mar 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! I left you some minor comments about the documentation
Co-authored-by: Jose Antonio Carmona <jcarmona@vmware.com> Signed-off-by: Francisco de Paz Galan <fdepaz@vmware.com>
6 tasks
joancafom
previously approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Huge PR! 🚀
aoterolorenzo
added a commit
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com>
aoterolorenzo
added a commit
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com>
Signed-off-by: FraPazGal <fdepaz@vmware.com>
Signed-off-by: FraPazGal <fdepaz@vmware.com>
Signed-off-by: FraPazGal <fdepaz@vmware.com>
joancafom
approved these changes
Mar 22, 2023
aoterolorenzo
added a commit
that referenced
this pull request
Mar 22, 2023
This reverts commit 0a96247.
4 tasks
2 tasks
aoterolorenzo
added a commit
that referenced
this pull request
Mar 23, 2023
Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com>
aoterolorenzo
pushed a commit
that referenced
this pull request
Mar 23, 2023
* [bitnami/*] Migrate VIB's runtime_params to independent file Signed-off-by: FraPazGal <fdepaz@vmware.com> * Adapt several test suites to use standarised runtime_params file Signed-off-by: FraPazGal <fdepaz@vmware.com> * Update testing doc Signed-off-by: FraPazGal <fdepaz@vmware.com> * Apply suggestions from code review Co-authored-by: Jose Antonio Carmona <jcarmona@vmware.com> Signed-off-by: Francisco de Paz Galan <fdepaz@vmware.com> * Fix migration issues for assets using multiple Goss actions Signed-off-by: FraPazGal <fdepaz@vmware.com> * Fix migration issues with assets using the goss-wait directive Signed-off-by: FraPazGal <fdepaz@vmware.com> * Fix quoting-related issues Signed-off-by: FraPazGal <fdepaz@vmware.com> --------- Signed-off-by: FraPazGal <fdepaz@vmware.com> Signed-off-by: Francisco de Paz Galan <fdepaz@vmware.com> Co-authored-by: Jose Antonio Carmona <jcarmona@vmware.com>
aoterolorenzo
added a commit
that referenced
this pull request
Mar 23, 2023
Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com>
mdhont
pushed a commit
to mdhont/charts
that referenced
this pull request
Mar 23, 2023
…#15510) * [bitnami/*] Migrate VIB's runtime_params to independent file Signed-off-by: FraPazGal <fdepaz@vmware.com> * Adapt several test suites to use standarised runtime_params file Signed-off-by: FraPazGal <fdepaz@vmware.com> * Update testing doc Signed-off-by: FraPazGal <fdepaz@vmware.com> * Apply suggestions from code review Co-authored-by: Jose Antonio Carmona <jcarmona@vmware.com> Signed-off-by: Francisco de Paz Galan <fdepaz@vmware.com> * Fix migration issues for assets using multiple Goss actions Signed-off-by: FraPazGal <fdepaz@vmware.com> * Fix migration issues with assets using the goss-wait directive Signed-off-by: FraPazGal <fdepaz@vmware.com> * Fix quoting-related issues Signed-off-by: FraPazGal <fdepaz@vmware.com> --------- Signed-off-by: FraPazGal <fdepaz@vmware.com> Signed-off-by: Francisco de Paz Galan <fdepaz@vmware.com> Co-authored-by: Jose Antonio Carmona <jcarmona@vmware.com>
aoterolorenzo
added a commit
that referenced
this pull request
Mar 27, 2023
Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com>
aoterolorenzo
added a commit
that referenced
this pull request
Apr 5, 2023
* Add flink Chart Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Set proper version Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix values and add extraDeploy feature Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Add flink tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Bind env var to helper and comment Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add trunc / trimSuffix Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add spacing Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Revert spacing Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add diagnostic mode notes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove unused references Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Remove unused references Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update http port Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Typo Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Complete README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update flinbk image Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Remove double blanklines Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update runtime parameters Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update runtime parameters and pull policy Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update http endpoint Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update valeues on runtime parameters Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update port name Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add vars to goss.yaml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix var declaration on goss.yaml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove bad spacing Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix taskmanager deployment port env var Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix jobmanager deployment port env var Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update cypress timeout Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update values after some fixes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update cypress tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update vars Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Increase timeout Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss vars Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Put cypress timeout on the moon Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add goss timeouts Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update runtime parameters Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add goss timeout Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove timeouts Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update timeouts Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update Cypress tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss command target Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update parameters to fix balancing problem Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove unrelated README.md references Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update Chart info Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add blob port prefix and quote unquoted values Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Test improvements Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update port bindings Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update runtime parameters Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add flink to cd-pipeline.yml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update impl for goss (add blob port vals) Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Timeout to 90s Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix dynamic blob port and apply impl to tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update port vars Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update rpc port names Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix port naming Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Adapt vib pipelines to #15510 Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update runtime-parameters.yaml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove unnecessary feature Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove vars.yaml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update jobmanager service test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add http port service check. Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * User host:port Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix value Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add container ports tests case Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove unused values Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove redundant test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add pod and container context values Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Minor fixes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update jobmanager deployment's container name Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add jobmanager.podSecurityContext.seccompProfile Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Add quote to env var Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> --------- Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
aoterolorenzo
added a commit
that referenced
this pull request
Apr 25, 2023
* Add base Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Working chart Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add daemonset Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add CR & CRB Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update impl Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add autoscalers Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add ingress Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add service monitor and pbd Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Disable daemonset by default Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update Chart impl details Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove unrelated references Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Revert unrelated changes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove blankline Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix lb values for testing Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add goss vars defs Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Lint issue Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Lint issue Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss file check Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update health check protocol Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update test lb port Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add fluent bit to cd-pipeline.yml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update test values Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update lb port var Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Minor fixes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove unnecessary volumes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Bind hpa.apiVersion to our common.capabilities Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix cr and crb conditions Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove BITNAMI_DEBUG support Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove ingress.servicePort Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update vib files to match #15510 changes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * fix vib definitions Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add vars file pointer Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * typo Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove vars Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fake version bump Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fake version bump revert Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove redundant parameter Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix file permissions check Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add .Values.rbac.rules Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Use fluent-bit as main template name Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove fluent-bit.ingress.hostname helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove ingress annotations helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix namespace values Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix persistence advise Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Dummy filter Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix ingress Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix filters Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update configmap.yaml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Parametrize hostNetwork and dnsPolicy Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * fluent-bit Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Disable deployment replication when hpa enabled Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove fluent-bit.kind helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add extraDeploy Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Fix NOTES.txt typo Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add tls-secret.yaml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * hpa and vpa annotations Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Improve service.ports.http goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Base conf dir goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * remove replicaCount Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * GENERIC -> HTTP Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add sa goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add deployment serviceAccount Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add daemonset exclusive podSecurityContext to run as root Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Parametrize hostPaths Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Fix daemonset usage boolean Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * UpFixdate goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix deployment condition Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix annotations and default to deployment Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix README.md and values docs Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * tcp -> http Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * tcp -> http Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add configmap helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> --------- Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
mweibel
pushed a commit
to mweibel/charts
that referenced
this pull request
Apr 27, 2023
* Add base Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Working chart Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add daemonset Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add CR & CRB Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update impl Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add autoscalers Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add ingress Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add service monitor and pbd Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Disable daemonset by default Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update Chart impl details Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove unrelated references Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Revert unrelated changes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove blankline Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix lb values for testing Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add goss vars defs Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Lint issue Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Lint issue Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss file check Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update health check protocol Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update test lb port Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add fluent bit to cd-pipeline.yml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update test values Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update lb port var Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Minor fixes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove unnecessary volumes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Bind hpa.apiVersion to our common.capabilities Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix cr and crb conditions Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove BITNAMI_DEBUG support Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove ingress.servicePort Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update vib files to match bitnami#15510 changes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * fix vib definitions Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add vars file pointer Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * typo Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove vars Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fake version bump Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fake version bump revert Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove redundant parameter Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix file permissions check Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add .Values.rbac.rules Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Use fluent-bit as main template name Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove fluent-bit.ingress.hostname helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove ingress annotations helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix namespace values Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix persistence advise Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Dummy filter Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix ingress Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix filters Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update configmap.yaml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Parametrize hostNetwork and dnsPolicy Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * fluent-bit Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Disable deployment replication when hpa enabled Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove fluent-bit.kind helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add extraDeploy Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Fix NOTES.txt typo Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add tls-secret.yaml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * hpa and vpa annotations Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Improve service.ports.http goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Base conf dir goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * remove replicaCount Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * GENERIC -> HTTP Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add sa goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add deployment serviceAccount Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add daemonset exclusive podSecurityContext to run as root Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Parametrize hostPaths Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Fix daemonset usage boolean Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * UpFixdate goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix deployment condition Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix annotations and default to deployment Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix README.md and values docs Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * tcp -> http Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * tcp -> http Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add configmap helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> --------- Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
Yaytay
pushed a commit
to Yaytay/charts
that referenced
this pull request
May 5, 2023
* Add base Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Working chart Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add daemonset Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add CR & CRB Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update impl Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add autoscalers Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add ingress Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add service monitor and pbd Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Disable daemonset by default Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update Chart impl details Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove unrelated references Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Revert unrelated changes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove blankline Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix lb values for testing Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add goss vars defs Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Lint issue Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Lint issue Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss file check Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update health check protocol Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update test lb port Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add fluent bit to cd-pipeline.yml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update test values Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update lb port var Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Minor fixes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove unnecessary volumes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Bind hpa.apiVersion to our common.capabilities Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix cr and crb conditions Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove BITNAMI_DEBUG support Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove ingress.servicePort Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update vib files to match bitnami#15510 changes Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * fix vib definitions Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add vars file pointer Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * typo Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove vars Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fake version bump Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fake version bump revert Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove redundant parameter Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix file permissions check Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add .Values.rbac.rules Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Use fluent-bit as main template name Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove fluent-bit.ingress.hostname helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove ingress annotations helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix namespace values Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix persistence advise Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Dummy filter Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix ingress Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix filters Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update configmap.yaml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Parametrize hostNetwork and dnsPolicy Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * fluent-bit Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Disable deployment replication when hpa enabled Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Remove fluent-bit.kind helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add extraDeploy Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Fix NOTES.txt typo Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add tls-secret.yaml Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * hpa and vpa annotations Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Improve service.ports.http goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Base conf dir goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * remove replicaCount Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * GENERIC -> HTTP Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add sa goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add deployment serviceAccount Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add daemonset exclusive podSecurityContext to run as root Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Parametrize hostPaths Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Fix daemonset usage boolean Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Update goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * UpFixdate goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix goss tests Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix deployment condition Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix goss test Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix annotations and default to deployment Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Fix README.md and values docs Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * tcp -> http Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * tcp -> http Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> * Add configmap helper Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> --------- Signed-off-by: Alberto Otero Lorenzo <lorenzoa@vmware.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR implements the usage of
runtime-parameters.yaml
files, deprecating their definition in thevib-*.json
pipelines DSLs as a base64 encoded string. The main changes this PR introduces are:.vib/asset/runtime-parameters.yaml
file containing the decoded string previously found atphases.verify.context.runtime_parameters
vars.yaml
files, Goss' vars file is nowruntime-parameters.yaml
Benefits
Possible drawbacks
main
to avoid conflicts in the CI/CD runs.The team will be internally notified of these changes to mitigate these issues.
Additional information
Some Goss tests needed to be adapted to the yaml structure of the new
runtime-parameters.yaml
. This was caused by the use of custom yaml structures invars.yaml
.Fixed some minor discrepancies between runtime_param and old vars.
Changes tested in fork:
ℹ️ Non-standard cases tested locally.
Checklist