Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/external-dns] add gloo-proxy rbac rules #5553

Merged
merged 1 commit into from
Feb 19, 2021
Merged

[bitnami/external-dns] add gloo-proxy rbac rules #5553

merged 1 commit into from
Feb 19, 2021

Conversation

jon-walton
Copy link
Contributor

@jon-walton jon-walton commented Feb 19, 2021 •
edited
Loading

Description of the change

This adds rbac rules in anticipation of gloo support being merged in kubernetes-sigs/external-dns#1693

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])

rafariossaa
rafariossaa approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thanks for adding this .
LGTM

@rafariossaa rafariossaa merged commit 8acd0a7 into bitnami:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafariossaa rafariossaa rafariossaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jon-walton @rafariossaa