Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing serialization support for Affine2 / DAffine2 / Affine3 / DAffine3 #209

Closed
0HyperCube opened this issue Jun 27, 2021 · 2 comments
Closed

Missing serialization support for Affine2 / DAffine2 / Affine3 / DAffine3 #209

0HyperCube opened this issue Jun 27, 2021 · 2 comments

Comments

@0HyperCube
Copy link

We're using glam in Graphite, and it would be useful for this PR to have DAffine2 able to be serialized without a proxy. Serde's Serialize seems to be implemented for all types except for these 4.

I assume it would be reasonably easy to add these?
@bitshifter
Copy link
Owner

Those types are new so probably I've forgotten to implement a bunch of optional features for them. They are composed from other types which do implement serialisation to it should be easy to add.

bitshifter added a commit that referenced this issue Jun 29, 2021
@bitshifter
Prepare 0.17.1 release (#211)
059f619 
#209
@bitshifter
Copy link
Owner

@0HyperCube These are in release 0.17.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitshifter @0HyperCube