Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to changelog #452

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Conversation

jlgeering
Copy link
Contributor

@jlgeering jlgeering commented Aug 4, 2018

link will be picked up by hex and added to https://hex.pm/packages/timex next time a version is published

for example see https://hex.pm/packages/quantum

Summary of changes

new "Changelog" link on https://hex.pm/packages/timex to https://github.com/bitwalker/timex/blob/master/CHANGELOG.md

Checklist

  • New functions have typespecs, changed functions were updated
  • Same for documentation, including moduledocs
  • Tests were added or updated to cover changes
  • Commits were squashed into a single coherent commit

will be picked up by hex and added to https://hex.pm/packages/timex next time a version is published
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 69.269% when pulling 464914f on jlgeering:link-to-changelog into ea3cd35 on bitwalker:master.

@jlgeering
Copy link
Contributor Author

Coverage decreased => that is unfair :-)

should I write a test that covers mix.exs ?

@bitwalker bitwalker merged commit 40646ec into bitwalker:master Aug 8, 2018
@bitwalker
Copy link
Owner

Yeah, coveralls is really dumb about calculating coverage, I probably just need to tweak some configuration to ignore mix.exs

@jlgeering jlgeering deleted the link-to-changelog branch August 8, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants