[PM-13673] Require UserId In CompareHash Method #11568
Open
+113
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11568 +/- ##
==========================================
+ Coverage 33.15% 33.17% +0.01%
==========================================
Files 2779 2779
Lines 86310 86314 +4
Branches 16445 16447 +2
==========================================
+ Hits 28618 28631 +13
+ Misses 55418 55405 -13
- Partials 2274 2278 +4 ☔ View full report in Codecov by Sentry. |
|
Fixed Issues
|
coroiu
approved these changes
Oct 16, 2024
rr-bw
approved these changes
Oct 16, 2024
shane-melton
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
Main goal is to require
UserIdon the existingcompareAndUpdateKeyHashfunction. When working on that method though it had a callout to remove the update and server compare part. While here I decided to remove that.I also refactored it to be flatter, all tests were added before the function changed to ensure equal behavior.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes