[PM-13687] Update search state to show contextually relevant no results view messages #11570
+36
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11570 +/- ##
==========================================
- Coverage 33.16% 33.15% -0.01%
==========================================
Files 2779 2779
Lines 86310 86314 +4
Branches 16445 16445
==========================================
- Hits 28621 28614 -7
- Misses 55415 55426 +11
Partials 2274 2274 ☔ View full report in Codecov by Sentry. |
jprusik
changed the title
jprusik
changed the title
|
No New Or Fixed Issues Found |
cagonzalezcs
previously approved these changes
Oct 15, 2024
cagonzalezcs
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-13687
📔 Objective
Note: follow up from PM-12368
When a user registers a new passkey via the extension popup and no login ciphers exist in the vault for that page, show a "No matching logins for this site" message with a search bar and button to save passkey as a new login. If the user searches from this view (or another view) and there are no login cipher matches for the search, display a "No items match your search" message with a button to clear search.
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes