Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13715] Launching a website from the extension does not trigger an update to reference the correct autofill value #11587

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

cagonzalezcs
Copy link
Contributor

@cagonzalezcs cagonzalezcs commented Oct 16, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13715

📔 Objective

An issue has been reported regarding the "launch URL" behavior that the extension can provide to users. In effect, we are seeing problems with the correct cipher being set to autofill on the launched website, both for the autofill on page load behavior and the keyboard shortcut.

The changes in this PR should resolve these issues, ensuring that users who launch a website from their vault cipher are able to do the following:

  • Trigger autofill of the corresponding cipher credentials on page load
  • Trigger autofill of the corresponding cipher credentials with the keyboard shortcut
  • View the corresponding launched cipher at the top of their list of recommended autofill options.

Resolves #1958

📸 Demo of the issue

Screen.Recording.2024-10-16.at.1.44.16.PM.mp4

📸 Demo of the fix

Screen.Recording.2024-10-16.at.1.46.13.PM.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Logo
Checkmarx One – Scan Summary & Detailsdc4ad35f-1f80-4aa7-b420-590b2eb2ee94

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 33.28%. Comparing base (97bf459) to head (268859b).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...utofill-options/autofill-options-view.component.ts 25.00% 2 Missing and 1 partial ⚠️
libs/common/src/vault/services/cipher.service.ts 0.00% 2 Missing ⚠️
...ibs/angular/src/vault/components/view.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11587      +/-   ##
==========================================
- Coverage   33.29%   33.28%   -0.01%     
==========================================
  Files        2785     2785              
  Lines       86559    86560       +1     
  Branches    16490    16490              
==========================================
- Hits        28818    28812       -6     
- Misses      55446    55453       +7     
  Partials     2295     2295              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cagonzalezcs cagonzalezcs marked this pull request as ready for review October 16, 2024 18:53
@cagonzalezcs cagonzalezcs requested a review from a team as a code owner October 16, 2024 18:53
Copy link
Member

@gbubemismith gbubemismith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launching an item doesn't auto-fill that item
2 participants