-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13715] Launching a website from the extension does not trigger an update to reference the correct autofill value #11587
base: main
Are you sure you want to change the base?
Conversation
…-doesnt-set-correct-autofill-action
…has been launched from browser extension
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11587 +/- ##
==========================================
- Coverage 33.29% 33.28% -0.01%
==========================================
Files 2785 2785
Lines 86559 86560 +1
Branches 16490 16490
==========================================
- Hits 28818 28812 -6
- Misses 55446 55453 +7
Partials 2295 2295 ☔ View full report in Codecov by Sentry. |
…-doesnt-set-correct-autofill-action
…-doesnt-set-correct-autofill-action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
…-doesnt-set-correct-autofill-action
…-doesnt-set-correct-autofill-action
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13715
📔 Objective
An issue has been reported regarding the "launch URL" behavior that the extension can provide to users. In effect, we are seeing problems with the correct cipher being set to autofill on the launched website, both for the autofill on page load behavior and the keyboard shortcut.
The changes in this PR should resolve these issues, ensuring that users who launch a website from their vault cipher are able to do the following:
Resolves #1958
📸 Demo of the issue
Screen.Recording.2024-10-16.at.1.44.16.PM.mp4
📸 Demo of the fix
Screen.Recording.2024-10-16.at.1.46.13.PM.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes