Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13449] Owner assignment/visibility in AC #11588

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nick-livefront
Copy link
Collaborator

@nick-livefront nick-livefront commented Oct 16, 2024

๐ŸŽŸ๏ธ Tracking

PM-13449

๐Ÿ“” Objective

Add policy logic to allow for users to either see or change the ownership of a cipher when in the admin console. Here's full conversation validating the experience with Danielle and Brad in slack.
In short:

  • New item: Hide the owner field and default to current org
  • Edit Item: Hide owner field
  • Clone item: Show owner and let user select any org or "You" from menu

@shane-melton This contradicts some of the feedback in #11249 so if we have more functionality to flush out here, we should have those conversations.

๐Ÿ“ธ Screenshots

Add/Edit no owner field Clone cipher with owner field
add-edit-cipher-no-owner.mov
clone-cipher-personal-owner.mov

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 91b7f932-7488-4553-a8eb-abc163ccfcf4

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.20%. Comparing base (d70d2cb) to head (e7cac40).
Report is 2 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rvices/admin-console-cipher-form-config.service.ts 86.66% 2 Missing โš ๏ธ
...nts/item-details/item-details-section.component.ts 66.66% 0 Missing and 1 partial โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11588      +/-   ##
==========================================
+ Coverage   33.19%   33.20%   +0.01%     
==========================================
  Files        2780     2780              
  Lines       86410    86424      +14     
  Branches    16469    16474       +5     
==========================================
+ Hits        28681    28698      +17     
+ Misses      55444    55440       -4     
- Partials     2285     2286       +1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant