Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13393] Remove animation from Generator dialog. #11591

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nick-livefront
Copy link
Collaborator

@nick-livefront nick-livefront commented Oct 16, 2024

🎟️ Tracking

PM-13393

📔 Objective

Remove slideIn animation as it doesn't support the "show animations" setting and adding a close animation is going to require a non-trivial solution. Dialog animations will be handled in https://bitwarden.atlassian.net/browse/PM-13766

📸 Screenshots

remove-animation.mov

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc7a7bc59-6100-4078-b30b-81ab206bd3c0

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 809 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 820 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.18%. Comparing base (8078946) to head (b27cb8e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11591      +/-   ##
==========================================
- Coverage   33.19%   33.18%   -0.01%     
==========================================
  Files        2780     2780              
  Lines       86411    86409       -2     
  Branches    16469    16469              
==========================================
- Hits        28681    28679       -2     
  Misses      55445    55445              
  Partials     2285     2285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants