[PM-13454] - Health report raw data and member count to uri #11596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## PM-13453 #11596 +/- ##
============================================
+ Coverage 33.16% 33.19% +0.03%
============================================
Files 2782 2783 +1
Lines 86508 86603 +95
Branches 16491 16512 +21
============================================
+ Hits 28688 28751 +63
- Misses 55535 55555 +20
- Partials 2285 2297 +12 ☔ View full report in Codecov by Sentry. |
djsmith85
requested changes
Oct 17, 2024
Comment on lines
+135
to
+138
| get trimmedURIs(): string[] { | ||
| return this.login?.uris?.map((u) => u.uri.replace(/(^\w+:|^)\/\//, "")) || []; | ||
| } | ||
|
|
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13454
📔 Objective
This PR adds a new component that displays the list of ciphers split up by host.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes