-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth/pm 8115/desktop extension UI refresh self hosted #11597
base: main
Are you sure you want to change the base?
Auth/pm 8115/desktop extension UI refresh self hosted #11597
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11597 +/- ##
==========================================
- Coverage 33.19% 33.16% -0.04%
==========================================
Files 2780 2782 +2
Lines 86411 86481 +70
Branches 16469 16489 +20
==========================================
- Hits 28688 28685 -3
- Misses 55438 55511 +73
Partials 2285 2285 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize that the task was not clear enough on this, but we do not need to modify the existing login components - only the new login component's env selector.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8115?atlOrigin=eyJpIjoiZjYxZDhiNjg1OWQwNDFlZGI3NWQyYmVkYTZlMGVhNGYiLCJwIjoiaiJ9
📔 Objective
Uses the new
RegistrationSelfHostedEnvConfigDialogComponent
as the dialog when selecting "self-hosted" from the server configuration on the login page. Also adjusts the leading text for the select based on whether theUnauthenticatedExtensionUIRefresh
is enabled.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes