Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12989] Create process for qa to build client with particular sdk version #11601

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Oct 17, 2024

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coroiu coroiu requested a review from a team as a code owner October 17, 2024 11:55
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.24%. Comparing base (85d4809) to head (276da3e).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                                       Coverage Diff                                       @@
##           PM-11764-implement-account-switching-and-sdk-initialization   #11601      +/-   ##
===============================================================================================
+ Coverage                                                        33.19%   33.24%   +0.04%     
===============================================================================================
  Files                                                             2779     2772       -7     
  Lines                                                            86362    86177     -185     
  Branches                                                         16452    16414      -38     
===============================================================================================
- Hits                                                             28666    28646      -20     
+ Misses                                                           55419    55263     -156     
+ Partials                                                          2277     2268       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Logo
Checkmarx One – Scan Summary & Details3c5ec214-ba0a-4121-8ee0-a6133283a985

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 312 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 915 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1363 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 78 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1317 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1363 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1317 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 915 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 312 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 78 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 288
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1339
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1293
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 891
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1293
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 891
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 288
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1339

@coroiu coroiu force-pushed the PM-12989-create-process-for-qa-to-build-client-with-particular-sdk-version branch 2 times, most recently from 0993fe9 to d07fe7c Compare October 17, 2024 12:20
@coroiu coroiu force-pushed the PM-12989-create-process-for-qa-to-build-client-with-particular-sdk-version branch from d07fe7c to 276da3e Compare October 17, 2024 12:23
Base automatically changed from PM-11764-implement-account-switching-and-sdk-initialization to main October 18, 2024 14:15
@coroiu coroiu dismissed michalchecinski’s stale review October 18, 2024 14:15

The base branch was changed.

@coroiu coroiu requested review from a team as code owners October 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants