Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13729] Show toast when copying SCIM api key and URL #11608

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BTreston
Copy link
Contributor

@BTreston BTreston commented Oct 17, 2024

🎟️ Tracking

PM-13729

📔 Objective

This PR adds calls to the toast service to show success toasts when copying a SCIM api key or URL.

📸 Screenshots

Screenshot 2024-10-17 at 2 38 37 PM
Screenshot 2024-10-17 at 2 38 32 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner October 17, 2024 18:40
@BTreston BTreston requested a review from r-tome October 17, 2024 18:40
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details12d8eb1f-f038-4cc1-ac77-72572f9deb02

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.20%. Comparing base (1d10f34) to head (9fb00fb).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...min-console/organizations/manage/scim.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11608      +/-   ##
==========================================
- Coverage   33.20%   33.20%   -0.01%     
==========================================
  Files        2782     2782              
  Lines       86484    86486       +2     
  Branches    16484    16484              
==========================================
  Hits        28721    28721              
- Misses      55476    55478       +2     
  Partials     2287     2287              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@r-tome r-tome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Please just add the ticket ID [PM-13729] to the PR title before merging.

@BTreston BTreston changed the title Show toast when copying SCIM api key and URL [PM-13729] Show toast when copying SCIM api key and URL Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants